intel / govmm / 348

81%

master: 81%

Pull #111

travis-ci

Refactor code to support multiple virtio transports at runtime

Currently, virtio transports for each device are determined with
architecture dependent build time conditionals. This isn't the ideal
solution, as virtio transports aren't exactly tied to the host's
architecture.

For example, aarch64 VMs do support both PCI and MMIO devices, and
after the recent introduction of the microvm machine type, that's also
the case for x86_64.

This patch extends each device that supports multiple transports with
a VirtioTransport field, so users of the library can manually specify
a transport for each device. To avoid breaking the compatibility, if
VirtioTransport is empty a behavior equivalent to the legacy one is
achieved by checking runtime.GOARCH and Config.Machine.Type.

I also added a global variable named "s390xTestOverride" to make the
code ignore runtime.GOARCH while running tests with tag "s390x_test",
do those can still pass while running on x86_64.

Keeping support for isVirtioPCI/isVirtioCCW in qmp.go is a bit
tricky. Eventually, the hot-plug API should be extended so callers
must manually specify the transport for the device.

Signed-off-by: Sergio Lopez <slp@redhat.com>

282 of 282 new or added lines in 2 files covered. (100.0%)

3153 of 4028 relevant lines covered (78.28%)

705.63 hits per line