4114
100%

Ran 16 Dec 2019 03:56PM UTC

Jobs 5

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 4114

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Incorrect status field in Application request (#1777)

Each Application (request for work on a given issue) had a `status`
field containing text version of the application status: Unreviewed,
Accepted, Rejected. However, because the application was saved
on IPFS in its entirety, including initial Unreviewed status,
it was ignoring further (post-request-review) status changes.

It was not a problem, because we never relied on the status being
correct. We use `review.approved` as the ultimately (and correct)
source of truth.

The choice was between fixing the status field and removing it.
The reasons for choosing to remove it instead of fixing are:
1. There is no analogous field in Work Submission,
2. It's more complicated to fix it - correct way of fixing it
   would require not storing it on IPFS == actively removing
   it from data we need to store on IPFS,
3. It's not in use anyway. We have another and equally correct
   way of determining the application status, and it is the same
   way we use for Work Submissions. Standards FTW.

Run Details

Jobs

ID	Job ID	Ran	Coverage
3	4114.3 (COVERALLS_PARALLEL=true COVERAGE=true)	16 Dec 2019 03:57PM UTC	93.88	Travis Job 4114.3
4	4114.4 (COVERALLS_PARALLEL=true COVERAGE=true)	16 Dec 2019 03:57PM UTC	97.18	Travis Job 4114.4
5	4114.5 (COVERALLS_PARALLEL=true COVERAGE=true)	16 Dec 2019 03:59PM UTC	98.67	Travis Job 4114.5
6	4114.6 (COVERALLS_PARALLEL=true COVERAGE=true)	16 Dec 2019 03:56PM UTC	97.74	Travis Job 4114.6
7	4114.7 (COVERALLS_PARALLEL=true COVERAGE=true)	16 Dec 2019 03:56PM UTC	100.0	Travis Job 4114.7

Source Files on build 4114

Detailed source file information is not available for this build.

AutarkLabs / open-enterprise / 4114
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4114

AutarkLabs / open-enterprise / 4114 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4114

AutarkLabs / open-enterprise / 4114
100%

README BADGES
x