CenterForOpenScience / waterbutler / 2859

76%

develop: 89%

Pull #391

travis-ci

Fix missing stream size when copy / move private files for figshare

* Copy / Move private files / datasets from figshare to OSFStorage
  or any working provider including figshare fails. The problem is
  that the downloaded stream from the src-provider  has a None size
  during copy / move, which  breaks the upload-to-dest step which
  requires the size.

* The root problem: the download response for private files using
  the figshare API does not provide the Content-Length header that
  is used to build the response stream and to set the stream size.
  On the contrary, the download response for published files using
  figshare's backend S3 API provides the Content-Length header.

* The fix is to retrieve and save the file size in advance during
  the metadata request and then create the response stream using
  this size if the Content-Length header is not provided.

9 of 9 new or added lines in 2 files covered. (100.0%)

5673 of 7453 relevant lines covered (76.12%)

0.76 hits per line