theory / fsa-rules / 29

98%

Pull #8

travis-ci

Performance enhancement for notes() method
Rewrite the method code to avoid unnecessary variable assignments and
jumping straight to the requested operation

Original times (from NYTProf):

sub notes {
  832	176431	25.2ms			    my $self = shift;
  833	176431	84.2ms			    my $fsa = $machines{$self};
  834	176431	22.2ms			    return $fsa->{notes} unless
  @_;
  835	176431	28.2ms			    my $key = shift;
  836	176431	386ms			    return $fsa->{notes}{$key}
  unless @_;
  837	44880	19.2ms			    $fsa->{notes}{$key} = shift;
  838	44880	110ms			    return $self;
  839					}

  After the change:

  sub notes {
    832
    833	176431	41.4ms		        return $machines{$_[0]}->{notes} if ($#_ == 0);
    834	176431	445ms			return $machines{$_[0]}->{notes}->{$_[1]} if ($#_ == 1);
    835	44880	46.8ms			$machines{$_[0]}->{notes}->{$_[1]} = $_[2] if ($#_ == 2);
    836	44880	115ms			return $_[0];
    837 }

It seems a small improvement (for having a not so easy to read code) but I'm invoking a lot of times this method

4 of 4 new or added lines in 1 file covered. (100.0%)

259 of 264 relevant lines covered (98.11%)

293.44 hits per line