alecthomas / injector / 424

94%

master: 96%

push

travis-ci

Fix a BoundKey UnknownProvider regression

The example of an error this regression caused:

    1302 A BoundKey provides a key to a type with pre-injected arguments.
    1303
    1304     >>> class A:
    1305     ...   def __init__(self, a, b):
    1306     ...     self.a = a
    1307     ...     self.b = b
    1308     >>> InjectedA = BoundKey(A, a=InstanceProvider(1), b=InstanceProvider(2))
    1309     >>> injector = Injector()
    1310     >>> a = injector.get(InjectedA)
    UNEXPECTED EXCEPTION: UnknownProvider("couldn't determine provider for InstanceProvider(1) to None")
    Traceback (most recent call last):
      File "/Users/user/projects/injector/injector/__init__.py", line 583, in get_binding
        return self._get_binding(interface, only_this_binder=is_scope)
      File "/Users/user/projects/injector/injector/__init__.py", line 578, in _get_binding
        raise KeyError
    KeyError

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/doctest.py", line 1329, in __run
        compileflags, 1), test.globs)
      File "<doctest injector.BoundKey[3]>", line 1, in <module>
      File "/Users/user/projects/injector/injector/__init__.py", line 864, in get
        result = scope_instance.get(interface, binding.provider).get(self)
      File "/Users/user/projects/injector/injector/__init__.py", line 289, in get
        return injector.call_with_injection(self._callable)
      File "/Users/user/projects/injector/injector/__init__.py", line 918, in call_with_injection
        owner_key=self_.__class__ if self_ is not None else callable.__module__,
      File "/Users/user/projects/injector/injector/__init__.py", line 80, in wrapper
        return function(*args, **kwargs)
      File "/Users/user/projects/injector/injector/__init__.py", line 959, in args_to_inject
        instance = self.get(... (continued)

300 of 330 branches covered (90.91%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

958 of 1014 relevant lines covered (94.48%)

2.83 hits per line