zooniverse / Panoptes-Front-End / 10386

56%

push

travis-ci

Ellipse region feedback (#5553)

* Added new elliptical region feedback based on radial

* Pre-testing for ellipse region feedback

* Pre-testing for ellipse region feedback - modified files.

* Pre-testing

* Passing tests

* Cosmetic formatting of formulae. Corrected spec strategies. Retored direct return of feedback marks.

* Added defaults for tolerance and theta. Updated tests appropriately. Removed ellipse-specific lab behaviour

* Changed feedback component name from ellipse to pointInEllipse

* Implemented some fixes indicated by failing tests. All tests now pass.

* Handle case when some props are numeric strings.

* Update app/features/feedback/shared/strategies/drawing/pointInEllipse/create-rule.spec.js

Co-Authored-By: srallen <srallen@users.noreply.github.com>

* Update app/features/feedback/shared/strategies/drawing/pointInEllipse/create-rule.spec.js

Co-Authored-By: srallen <srallen@users.noreply.github.com>

* Update app/features/feedback/shared/strategies/drawing/pointInEllipse/reducer.js

Co-Authored-By: srallen <srallen@users.noreply.github.com>

* Update app/features/feedback/shared/strategies/drawing/pointInEllipse/create-rule.spec.js

Co-Authored-By: srallen <srallen@users.noreply.github.com>

* Changed feedback attribute names for axis tolerances.

* Update app/features/feedback/shared/strategies/drawing/pointInEllipse/README.md

Co-Authored-By: srallen <srallen@users.noreply.github.com>

* Update app/features/feedback/shared/strategies/drawing/pointInEllipse/README.md

Co-Authored-By: srallen <srallen@users.noreply.github.com>

2008 of 5526 branches covered (36.34%)

Branch coverage included in aggregate %.

6691 of 12126 relevant lines covered (55.18%)

6.17 hits per line