ooni / probe-engine / 346

83%

master: 86%

Pull #156

travis-ci

[API CHANGE] Refactor code for fetching test lists

1. using a "client" for a test lists query is overkill, instead just
have a single function with config and possibly result (the same
concept can be applied to other places in the codebase, in which we
create "client" instances we don't actually need)

2. make sure the toplevel API can be used from mobile code, i.e., avoid
using a vector that gomobile cannot bind

3. verify, by looking at changed tests and miniooni, that the result
API is still reasonably non-painful to use

4. make sure that the internal implementation details are part of the
internal package: we're currently exposing too much internals

These changes are yak shaving I implemented while starting the work
to implement authenticated request for orchestra (i.e. #148)

55 of 55 new or added lines in 3 files covered. (100.0%)

1866 of 2240 relevant lines covered (83.3%)

0.93 hits per line