36409
33%

Ran 07 Dec 2019 12:53AM UTC

Jobs 1

Files 552

Run time 34s

Badge

Embed ▾

pending completion

Build # 36409

Build Type

push

travis-ci

Committed by

ZhilkinSerg

Commit Message

Implement iterators for JsonArray: (#35852)

* Rename JsonArray::end member to avoid conflict later

* Make some member functions of JsonArray const.

* Use size_t instead of int as index value in JsonArray

* Implement iterators for JsonArray:

This allows to iterate over a `JsonArray` with a range-based for loop.

Changes some code to use the form of iterating. This now also works with unnamed `JsonArray` instances, e.g. `for( ... : foo.get_array( ... ) )`.

* Fix test errors from unvisited JSON object members.

Functions take a copy of the JSON object, so the members in the original object are never visited and that is reported as error.

* Fix variable name collision in *some* compilers.

Yes, I'm looking at you GCC 5.3.1.

Run Details

207 of 207 new or added lines in 33 files covered. (100.0%)

39213 of 142107 relevant lines covered (27.59%)

517473.89 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	24.39	-0.1%	src/magic.cpp
1	9.47	0.2%	src/magic_teleporter_list.cpp
1	24.98	-0.85%	src/mapgen.cpp
1	64.95	0.6%	src/mod_manager.cpp
1	82.82	0.42%	src/npc_class.cpp
1	80.36	0.13%	src/profession.cpp
2	83.51	0.09%	src/monstergenerator.cpp
2	35.1	0.02%	src/npc.cpp
2	8.55	0.03%	src/panels.cpp
2	1.72	0.11%	src/relic.cpp
2	14.86	0.0%	src/worldfactory.cpp
3	23.89	-1.71%	src/magic_ter_fur_transform.cpp
3	0.52	-0.09%	src/savegame.cpp
4	79.56	0.06%	src/mutation_data.cpp
4	71.54	0.11%	src/regional_settings.cpp
10	68.54	0.44%	src/json.cpp
15	12.78	0.15%	src/savegame_json.cpp

Uncovered Existing Lines

Lines	Coverage	∆	File
1	11.5	-0.02%	src/game.cpp
1	64.95	0.6%	src/mod_manager.cpp
1	30.54	-0.12%	src/monmove.cpp
1	35.1	0.02%	src/npc.cpp
2	58.71	-1.0%	src/calendar.cpp
2	3.12	-0.18%	src/map_field.cpp
2	57.83	-2.88%	src/mapgendata.cpp
2	22.82	-0.1%	src/melee.cpp
2	8.55	0.03%	src/panels.cpp
3	77.53	-0.95%	src/item_group.cpp
3	68.54	0.44%	src/json.cpp
3	48.82	-0.44%	src/mutation.cpp
3	79.56	0.06%	src/mutation_data.cpp
3	76.47	-17.97%	src/vehicle_group.h
4	48.0	-4.0%	src/field.cpp
4	80.71	-0.19%	src/overmap.cpp
9	47.38	-0.06%	src/character.cpp
11	36.36	-33.33%	src/weighted_list.h
15	49.01	-0.33%	src/item.cpp
18	11.47	-0.76%	src/newcharacter.cpp
18	13.28	-1.72%	src/suffer.cpp
18	50.41	-7.44%	src/vehicle_part.cpp
28	36.09	-23.77%	src/vehicle_group.cpp
29	24.98	-0.85%	src/mapgen.cpp
32	53.46	-1.07%	src/vehicle.cpp
35	44.04	-0.87%	src/map.cpp
97	0.11	0.0%	src/overmap_ui.cpp
104	10.75	-7.19%	src/map_extras.cpp
171	16.1	-4.41%	src/mapgen_functions.cpp

Jobs

ID	Job ID	Ran	Files	Coverage
10	36409.10 (COMPILER=g++-6 CODE_COVERAGE=true)	07 Dec 2019 12:53AM UTC	552	27.59	Travis Job 36409.10

CleverRaven / Cataclysm-DDA / 36409
33%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 36409

CleverRaven / Cataclysm-DDA / 36409 33%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 36409

CleverRaven / Cataclysm-DDA / 36409
33%

README BADGES
x