1005
57%

Ran 05 Jun 2015 05:52PM UTC

Jobs 1

Files 81

Run time 6s

Badge

Embed ▾

pending completion

Build # 1005

Build Type

Pull #302

travis-ci

Committed by

thibaultCha

Commit Message

chore(dao) separate plugin-specific daos from core

- Plugins can now have their own DAO(s) in a `daos.lua` file. The
  returned table for this file is a list of all DAOs for this plugin, so
  a plugin can have multiple DAOs to be future-proof.
- TRUNCATE queries now belong to their respective DAO.
- Migrations DAO is only loaded if explicitly asked. Thus Only
  `kong.tools.migrations` loads it.
- DAOs now have a reference to the Factory: `self._factory`
- DAOs now belong to factory.daos[dao_name] but can be accessed via
  a shorthand `__index` method: factory[dao_name] for backward
  compatibility

A lot of work is still needed to have a proper plugin architecure:

- Remove tests in the core that rely on some of the plugins. Examples:
  - `database_cache_spec` find another way to test that
  - `cassandra_spec` move those to their respective plugin
- Implement per-plugin migrations

Pull Request Pull Request #302: [feature] Plugin DAOs

Run Details

1821 of 2923 relevant lines covered (62.3%)

46.68 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	96.05	0.05%	./kong/dao/cassandra/plugins_configurations.lua
4	93.85	7.28%	./kong/dao/cassandra/factory.lua
7	83.33	-3.97%	./kong/tools/utils.lua
31	45.0	0.84%	./kong/tools/migrations.lua
44	14.78	0.73%	./kong/kong.lua

Jobs

ID	Job ID	Ran	Files	Coverage
1	1005.1 (LUA=lua5.1)	05 Jun 2015 05:52PM UTC	81	62.3	Travis Job 1005.1

Source Files on build 1005

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

Mashape / kong / 1005
57%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1005

Mashape / kong / 1005 57%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1005

Mashape / kong / 1005
57%

README BADGES
x