12304
37%

Ran 02 Dec 2019 02:32AM UTC

Jobs 1

Files 85

Run time 22s

Badge

Embed ▾

pending completion

Build # 12304

Build Type

push

travis-ci

Committed by

jay

Commit Message

build: Disable Visual Studio warning "conditional expression is constant"

- Disable warning C4127 "conditional expression is constant" globally
  in curl_setup.h for when building with Microsoft's compiler.

This mainly affects building with the Visual Studio project files found
in the projects dir.

Prior to this change the cmake and winbuild build systems already
disabled 4127 globally for when building with Microsoft's compiler.
Also, 4127 was already disabled for all build systems in the limited
circumstance of the WHILE_FALSE macro which disabled the warning
specifically for while(0). This commit removes the WHILE_FALSE macro and
all other cruft in favor of disabling globally in curl_setup.

Background:

We have various macros that cause 0 or 1 to be evaluated, which would
cause warning C4127 in Visual Studio. For example this causes it:

    #define Curl_resolver_asynch() 1

Full behavior is not clearly defined and inconsistent across versions.
However it is documented that since VS 2015 Update 3 Microsoft has
addressed this somewhat but not entirely, not warning on while(true) for
example.

Prior to this change some C4127 warnings occurred when I built with
Visual Studio using the generated projects in the projects dir.

Closes https://github.com/curl/curl/pull/4658

Run Details

3807 of 5239 relevant lines covered (72.67%)

0.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
28	12304.28 (T=coverage OVERRIDE_CC="CC=gcc-8" OVERRIDE_CXX="CXX=g++-8")	02 Dec 2019 02:32AM UTC	0	74.74	Travis Job 12304.28

Source Files on build 12304

Detailed source file information is not available for this build.

curl / curl / 12304
37%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12304

curl / curl / 12304 37%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12304

curl / curl / 12304
37%

README BADGES
x