gap-system / gap / 10997

4%

Build Type

push

travis-ci

Committed by ChrisJefferson

Commit Message

Fix bugs in HPC-GAP serialization code and improve its tests

In particular, DeserializeObjMap was buggy and created an object *set*.

Serializing a plain record did not take negative rnams into account and
thus would crash or produce garbage.

Both issues were found by improving the tests; specifically, by fixing
them to actually *test* anything -- before, CheckSerialization and
CheckSerialization2 never ever raised an error (unless serialization or
deserialization outright raise an error). Now we check stuff, and this
immediately revealed some bugs (and a few more were revealed by further
tests I added).

Run Details

4 of 4 new or added lines in 2 files covered. (100.0%)

33 existing lines in 1 file now uncovered.

285736 of 337452 relevant lines covered (84.67%)

29969271.14 hits per line