gchaincl / sqlhooks / 142

76%

push

travis-ci

Ccmtaylor compose (#28)

* make testHooks implement OnErrorer

* allow composing Hooks

adds func Compose that allows composing multiple Hooks into one.
It runs every callback on every hook in argument order,
even if previous hooks return an error.
If multiple hooks return errors, the error return value will be
MultipleErrors, which allows for introspecting the errors if necessary.

I chose not to abort processing when any handler returns an error,
because common usage would be to compose logging / tracing / metrics,
and those kinds of handlers will want to run in every case to make
sure that e.g. latencies are tracked correctly.

I added compatibility with Go 1.13's errors.Is/errors.As methods under
a conditional compilation flag.

Fixes: #12

* extract function for error handling

57 of 57 new or added lines in 2 files covered. (100.0%)

398 of 542 relevant lines covered (73.43%)

24.8 hits per line