jekyll / jekyll-admin / 1776

73%

push

travis-ci

Render icons in Button based on the `type` prop (#541)

Most of the buttons have their icons fixed for a given type to ease UX.
For example, `delete` type buttons are always rendered with the `trash` icon, or the `view` buttons are always rendered with the `eye` icon and similarly the `save` buttons are always rendered with the `save (floppy)` icon.

So instead of having to repeatedly pass the icon-name as a prop for the same Button type, it is better if the Button component determined the icon based on the current type.

Nevertheless, the existing behavior of passing `icon` as a prop is still valid to allow rendering a *variant* of the button with a different icon if such a need arises.

1026 of 1350 branches covered (76.0%)

Branch coverage included in aggregate %.

2296 of 2784 relevant lines covered (82.47%)

25.3 hits per line