gap-system / gap / 10963

4%

Build Type

push

travis-ci

Committed by ChrisJefferson

Commit Message

Sync some diffs between hpcgap/lib and lib

Also fix what looks like a race condition in TYPE_VEC8BIT resp.
TYPE_VEC8BIT_LOCKED: if two threads called these at the same time, they
might create two different type object A and B for the same parameters.
Then the first thread might call InstallTypeSerializationTag with type
A, which installs that type; then execution switches to the second
thread, which also calls InstallTypeSerializationTag (overriding the
installed value with B); the execution switches back to the first
thread, which sets TYPES_VEC8BIT[col][q] to A; and then thread 2
resumes; it also tries to set TYPES_VEC8BIT[col][q], but since there is
already a value in this write-once atomic list, it does nothing.

In the end, A is in TYPES_VEC8BIT and B in DESERIALIZATION_TAG_INT_NEW,
which is not what we want.

So instead, we first set TYPES_VEC8BIT[col][q]; then read back the value
from there and pass that to InstallTypeSerializationTag.

Run Details

55 of 79 new or added lines in 5 files covered. (69.62%)

5 existing lines in 1 file now uncovered.

285739 of 337447 relevant lines covered (84.68%)

30033361.48 hits per line