1445
92%
master: 92%

Ran 21 Nov 2019 05:36PM UTC

Jobs 4

Files 654

Run time 20min

Badge

Embed ▾

pending completion

Build # 1445

Build Type

push

travis-ci

Committed by

jamadden

Commit Message

Fix sqlite+gevent deadlocks.

The problem happened if we switched away from a connection holding locks and into one that wanted to take those same locks *without* switching. This could be non-deterministic.

The solution was to move those operations that take locks into gevent's threadpool so they're guaranteed not to block the event loop. Fixes #382.

Add tests for this scenario. Also, CI wasn't properly testing gevent monkey-patching because of a bug in gevent.monkey. Workaround that and fix the issue that the gevent.monkey bug was hiding (around mixing of real native threads and greenlets).

Run Details

185 of 185 new or added lines in 6 files covered. (100.0%)

54323 of 59367 relevant lines covered (91.5%)

3.65 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
3	92.83	0.91%	src/relstorage/blobhelper/cached.py
20	90.38	-1.69%	src/relstorage/adapters/sqlite/drivers.py

Uncovered Existing Lines

Lines	Coverage	∆	File
1	92.0	-1.33%	src/relstorage/adapters/oidallocator.py
1	93.6	-0.8%	src/relstorage/adapters/postgresql/adapter.py
1	90.38	-1.69%	src/relstorage/adapters/sqlite/drivers.py
1	94.79	0.0%	src/relstorage/cache/storage_cache.py
1	91.53	-0.42%	src/relstorage/tests/RecoveryStorage.py
1	90.0	0.91%	src/relstorage/_util.py
2	98.59	-1.41%	src/relstorage/blobhelper/tests/test_cached.py
2	96.3	-0.82%	src/relstorage/tests/__init__.py
3	95.72	-1.6%	src/relstorage/adapters/connmanager.py
3	88.89	-4.76%	src/relstorage/adapters/_util.py
3	98.97	-0.77%	src/relstorage/tests/hptestbase.py
3	95.96	-3.03%	src/relstorage/zodburi_resolver.py
4	96.4	-3.6%	src/relstorage/cache/tests/test_cache_stats.py
6	92.89	-2.84%	src/relstorage/adapters/drivers.py
37	58.16	-26.24%	src/relstorage/_compat.py
51	43.33	-56.67%	src/relstorage/adapters/postgresql/drivers/pg8000.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	1445.1	21 Nov 2019 05:56PM UTC	218	91.75	Travis Job 1445.1
4	1445.4	21 Nov 2019 05:49PM UTC	218	91.92	Travis Job 1445.4
5	1445.5	21 Nov 2019 05:36PM UTC	218	90.21	Travis Job 1445.5
6	1445.6	21 Nov 2019 05:50PM UTC	218	91.79	Travis Job 1445.6

zodb / relstorage / 1445
92%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 1445

zodb / relstorage / 1445 92% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 1445

zodb / relstorage / 1445
92%
master: 92%

README BADGES
x