gryffon / ringteki / 7060

87%

develop: 38%

push

travis-ci

TEL - Total Warfare (#3630)

* TEL - Kitsu Motso

- Work in progress

* Trying to get provinces passed as attachable cards.

* Add attachment conditions

* Total Warfare happy path

* Total Warfare testing

Also trying to get flipping and discarding of attachments to work.

* Remove references to attachToProvinceAction

* Don't discard attachments on flip

* Fix tests and attaching to province

* Go back to checking cardtype for province to attach to

* Fix code style breaches

* Fix lint errors

* apply attachment limit and more tests

* add trait limits to attachment conditions

* add test for VoH double-attachment crash

* Added test to verify detachment of second attached Watch Commander (#4)

* Remove lasting effects in leavePlayEventHandler

Done as a test to see if this fixes the issue around turning dynasty characters into attachments (VotA)

* Update game engine to check for illegal attachments on provinces (#5)

* Cards in discard piles use printed type to determine location legality.

* Fix: Allow provinces to check for and remove illegal attachments.
Fix: when discarding cards, fallback to type if printedType doesn't exist.
Minor test cleanup

* Corrected log message. It not English so good.

* Also render stronghold province attachments and don't reveal facedown name

* Rework traitlimit definition

* - Move attachment functionality to Basecard

* Fix linting errors

5491 of 7074 branches covered (77.62%)

138 of 138 new or added lines in 10 files covered. (100.0%)

13938 of 15991 relevant lines covered (87.16%)

70413.57 hits per line