zendframework / zend-mail / 20

38%

Pull #6

travis-ci

Protocol\Smtp->data(): be more memory friendly (strpos/substr version)

With huge mails (50M, 660000 lines), i'm hitting memory_limit, so i've done some tests
looking at peak memory usage and average time(100 runs)
- str_replace("\r","") + explode("\n") 250M/0,27s (what we use now)
- preg_split("\r?\n") 200M/1,5s (too slow)
- strtok("\n") + rtrim("\r") 100M/0,27s (convert multiple \n\n\n in 1 -> ko)
- strpos("\n") + substr() 50M/0,35s
- fwrite(php://temp) + stream_get_line 50M/0,29s

All tests were run with 'php -d"memory_limit=256M" -d"opcache.enable_cli=1"'
With that many iteration (660000), factoring escape+send cost ~0.1s

Before this patch, we were removing \r, now we're keeping them,
in any case \r should be encoded

Signed-off-by: Etienne CHAMPETIER <etienne.champetier@fiducial.net>

13 of 13 new or added lines in 1 file covered. (100.0%)

1536 of 3790 relevant lines covered (40.53%)

9.45 hits per line