expressjs / session / 1135

100%

master: 100%

Pull #715

travis-ci

fix: reload calls exceeding stack track in case of errors

When `reload`'s callback is called, it invokes `wrapmethods` on the
request session, ensuring the new session's `reload` call is overriden
with a custom `reload`, calling the original. However, there's no
guarantee a new session is created, resulting in `reload` overriding
an overriden `reload`! Given enough such override-overrides, the stack
will overflow, gruesomely erupting into several hundreds of lines of
callstack, leaving the lonely developer to wonder how he has reached
such a mess, reflecting on several important life choices.

Note that the testing framework, for reasons beyond my current
comprehension, did not correctly act upon this `RangeError`. When
running the new test case without the fix, the `mocha` call hangs
seemingly indefinitely. That may be deserving of further research, but
most deserving of a word of warning.

2856 of 2964 branches covered (96.36%)

3 of 3 new or added lines in 1 file covered. (100.0%)

4692 of 4692 relevant lines covered (100.0%)

1095.8 hits per line