zendframework / zend-mail / 17

38%

Pull #5

travis-ci

Protocol\Smtp->data(): be more memory friendly

With huge mails (50M), i'm hitting memory_limit, so i've done some tests
looking at peak memory usage and average time(10 runs)
- str_replace("\r","") + explode("\n") 250M/0,27s (what we use now)
- preg_split("\r?\n") 200M/1,5s
- strtok("\n") + rtrim("\r") 100M/0,27s
- strpos("\n") + substr() 50M/0,50s

All tests were run with 'php -d"memory_limit=256M" -d"opcache.enable_cli=1"'
I've choose strtok because it's the best balance between time and memory

Before this patch, we were removing \r, now we're keeping them,
in any case \r should be encoded

Signed-off-by: Etienne CHAMPETIER <etienne.champetier@fiducial.net>

6 of 6 new or added lines in 1 file covered. (100.0%)

1531 of 3782 relevant lines covered (40.48%)

9.46 hits per line