1849
38%

Ran 13 Nov 2019 01:14PM UTC

Jobs 1

Files 44

Run time 3s

Badge

Embed ▾

pending completion

Build # 1849

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Diagnostics rework (#754)

* Inject DiagnosticsUI

Removes a use of global_events.
Encapsulate state instead of storing it on the module.

* Rename to DiagnosticsStorage and DiagnosticsPresenter

* Remove show_diagnostics_phantoms feature

* Implement diagnostics-on-save

* Run all updates in one walk over diagnostics structure

* Remove unneeded condition and unused function

* Remove duplication in finding diagnostics at cursor.

* Diagnostics lookup fixes

Cursor listener should include from entire line
Filter on lsp range/point instead of sublime position

Also set status on active view

* Reduce use of view_diagnostics / get_window_diagnostics

* Remove other phantom logic

Thought about implementing F8 toggle a-la-VSCode, but can do that later.

* Fix DiagnosticsCursorListener not init-ing super.

* change auto_show_diagnostics_panel setting to "always", "saved", "never"

* Make sure HasRelevantDiagnostics always has a result

* Name function after the setting it reads.

Run Details

1385 of 3972 relevant lines covered (34.87%)

0.35 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1849.1	13 Nov 2019 01:14PM UTC	0	34.87	Travis Job 1849.1

Source Files on build 1849

Detailed source file information is not available for this build.

tomv564 / LSP / 1849
38%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1849

tomv564 / LSP / 1849 38%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1849

tomv564 / LSP / 1849
38%

README BADGES
x