• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

exAspArk / graphql-errors / 56
100%

Build:
DEFAULT BRANCH: master
Ran 12 Nov 2019 08:56PM UTC
Jobs 2
Files 1
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
56

push

travis-ci

exAspArk
Feature: handle rescue_from Module arguments properly (#19)

There is a common pattern for `rescue_from` and alike methods usage, to
pass as an argument a module which handles similar exceptions
processing. The most useful case (and the reason why I proposed that
change) is to handle different network errors with only on class.

In our project it's called Handle::NetworkErrors, it's a module which
aggregates handling of more then 20 different errors whose meaning is
just "something was wrong with the network" and in 99% of the cases it's
reasonable to handle them in exact similar way.

Unfortunately, without proposed change it's impossible to pass to
graphql-errors `rescue_from` a module. It has to be a class...
The other implementations of same method in Rails and Sidekiq accepts
Module as well as a Class.

So, my point is that would be great to have `rescue_from` behavior in a
cannonical way (or you may call it, principle of least surprise).

4 of 4 new or added lines in 1 file covered. (100.0%)

40 of 40 relevant lines covered (100.0%)

101.23 hits per line

Jobs
ID Job ID Ran Files Coverage
1 56.1 (2.3.8, GRAPHQL_RUBY_VERSION=1_7, graphql-1.7.gemfile) 12 Nov 2019 08:56PM UTC 0
100.0
Travis Job 56.1
2 56.2 (2.3.8, GRAPHQL_RUBY_VERSION=1_8, graphql-1.8.gemfile) 12 Nov 2019 08:56PM UTC 0
100.0
Travis Job 56.2
Source Files on build 56
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #56
  • 48e9815c on github
  • Prev Build on master (#52)
  • Next Build on master (#57)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc