allenwq / devise-multi_email / 217

96%

push

travis-ci

<a href="https://github.com/allenwq/devise-multi_email/commit/<a class=hub.com/allenwq/devise-multi_email/commit/97a522f32c86abba89397b8343e39361485a7cae">97a522f32<a href="https://github.com/allenwq/devise-multi_email/commit/97a522f32c86abba89397b8343e39361485a7cae">&quot;&gt;Permit Devise.allow_unconfirmed_access to be nil (#44)

Devise currently permits indefinite unconfirmed access when
`Devise.allow_unconfirmed_access` is set to `nil`.

See:
https://github.com/plataformatec/devise/blob/</a><a class="double-link" href="https://github.com/allenwq/devise-multi_email/commit/<a class="double-link" href="https://github.com/allenwq/devise-multi_email/commit/14863ba4c92cd9781a961be0486f0ea7dfe84144">14863ba4c</a>">14863ba4c</a><a href="https://github.com/allenwq/devise-multi_email/commit/97a522f32c86abba89397b8343e39361485a7cae">/lib/generators/templates/devise.rb#L139-L140

However, at present setting this parameter to nil results in NoMethodErrors
when evaluating the following:

```
def email=(new_email)
  multi_email.change_primary_email_to(new_email, allow_unconfirmed: Devise.allow_unconfirmed_access_for &gt; 0.days)
end
```

This commit creates a new method that checks to ensure if the Devise
configuration permits any period in which an unconfirmed may log in
and uses it to determine whether or not an unconfirmed email address
may be added to a user.

2 of 2 new or added lines in 1 file covered. (100.0%)

1318 of 1383 relevant lines covered (95.3%)

148.52 hits per line