324
87%

Ran 08 Nov 2019 08:33PM UTC

Jobs 30

Files 48

Run time 3min

Badge

Embed ▾

pending completion

Build # 324

Build Type

push

travis-ci

Committed by

albus522

Commit Message

Refactor sql statement

Before

`(run_at <= ? AND (locked_at IS NULL OR locked_at < ?) OR locked_by =
?) AND failed_at IS NULL`

This sql statement is really confusing for sql newbie.

After

`((run_at <= ? AND (locked_at IS NULL OR locked_at < ?)) OR locked_by =
?) AND failed_at IS NULL`

`And` has precedence over `Or`. they are equal.

So this change will not break currently behavior. Just make it more plain for sql newbie.

Reviewed by David Genord and Guihere Cavalcanti

Run Details

1785 of 2112 relevant lines covered (84.52%)

508.41 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	86.59	-0.91%	lib/delayed/backend/active_record.rb

Jobs

ID	Job ID	Ran	Files	Coverage
1	324.1 (2.3.8, gemfiles/mysql2/4-2.gemfile)	08 Nov 2019 08:33PM UTC	2	45.45	Travis Job 324.1
2	324.2 (2.3.8, gemfiles/mysql2/5-1.gemfile)	08 Nov 2019 08:33PM UTC	2	76.14	Travis Job 324.2
3	324.3 (2.3.8, gemfiles/mysql2/5-2.gemfile)	08 Nov 2019 08:33PM UTC	2	76.14	Travis Job 324.3
4	324.4 (2.3.8, gemfiles/postgresql/4-2.gemfile)	08 Nov 2019 08:33PM UTC	2	45.45	Travis Job 324.4
5	324.5 (2.3.8, gemfiles/postgresql/5-1.gemfile)	08 Nov 2019 08:33PM UTC	2	81.82	Travis Job 324.5
6	324.6 (2.3.8, gemfiles/postgresql/5-2.gemfile)	08 Nov 2019 08:33PM UTC	2	81.82	Travis Job 324.6
7	324.7 (2.3.8, gemfiles/sqlite3/4-2.gemfile)	08 Nov 2019 08:33PM UTC	2	45.45	Travis Job 324.7
8	324.8 (2.3.8, gemfiles/sqlite3/5-1.gemfile)	08 Nov 2019 08:33PM UTC	2	78.41	Travis Job 324.8
9	324.9 (2.3.8, gemfiles/sqlite3/5-2.gemfile)	08 Nov 2019 08:33PM UTC	2	78.41	Travis Job 324.9
10	324.10 (2.4.6, gemfiles/mysql2/4-2.gemfile)	08 Nov 2019 08:34PM UTC	2	45.45	Travis Job 324.10
11	324.11 (2.4.6, gemfiles/mysql2/5-1.gemfile)	08 Nov 2019 08:34PM UTC	2	76.14	Travis Job 324.11
12	324.12 (2.4.6, gemfiles/mysql2/5-2.gemfile)	08 Nov 2019 08:34PM UTC	2	76.14	Travis Job 324.12
13	324.13 (2.4.6, gemfiles/postgresql/4-2.gemfile)	08 Nov 2019 08:34PM UTC	2	45.45	Travis Job 324.13
14	324.14 (2.4.6, gemfiles/postgresql/5-1.gemfile)	08 Nov 2019 08:34PM UTC	2	81.82	Travis Job 324.14
15	324.15 (2.4.6, gemfiles/postgresql/5-2.gemfile)	08 Nov 2019 08:34PM UTC	2	81.82	Travis Job 324.15
16	324.16 (2.4.6, gemfiles/sqlite3/4-2.gemfile)	08 Nov 2019 08:34PM UTC	2	45.45	Travis Job 324.16
17	324.17 (2.4.6, gemfiles/sqlite3/5-1.gemfile)	08 Nov 2019 08:34PM UTC	2	78.41	Travis Job 324.17
18	324.18 (2.4.6, gemfiles/sqlite3/5-2.gemfile)	08 Nov 2019 08:35PM UTC	2	78.41	Travis Job 324.18
19	324.19 (2.5.5, gemfiles/mysql2/4-2.gemfile)	08 Nov 2019 08:34PM UTC	2	45.45	Travis Job 324.19
20	324.20 (2.5.5, gemfiles/mysql2/5-1.gemfile)	08 Nov 2019 08:35PM UTC	2	76.14	Travis Job 324.20
21	324.21 (2.5.5, gemfiles/mysql2/5-2.gemfile)	08 Nov 2019 08:35PM UTC	2	76.14	Travis Job 324.21
22	324.22 (2.5.5, gemfiles/mysql2/6-0.gemfile)	08 Nov 2019 08:35PM UTC	2	76.14	Travis Job 324.22
23	324.23 (2.5.5, gemfiles/postgresql/4-2.gemfile)	08 Nov 2019 08:35PM UTC	2	45.45	Travis Job 324.23
24	324.24 (2.5.5, gemfiles/postgresql/5-1.gemfile)	08 Nov 2019 08:36PM UTC	2	81.82	Travis Job 324.24
25	324.25 (2.5.5, gemfiles/postgresql/5-2.gemfile)	08 Nov 2019 08:36PM UTC	2	81.82	Travis Job 324.25
26	324.26 (2.5.5, gemfiles/postgresql/6-0.gemfile)	08 Nov 2019 08:36PM UTC	2	81.82	Travis Job 324.26
27	324.27 (2.5.5, gemfiles/sqlite3/4-2.gemfile)	08 Nov 2019 08:36PM UTC	2	45.45	Travis Job 324.27
28	324.28 (2.5.5, gemfiles/sqlite3/5-1.gemfile)	08 Nov 2019 08:36PM UTC	2	78.41	Travis Job 324.28
29	324.29 (2.5.5, gemfiles/sqlite3/5-2.gemfile)	08 Nov 2019 08:36PM UTC	2	78.41	Travis Job 324.29
30	324.30 (2.5.5, gemfiles/sqlite3/6-0.gemfile)	08 Nov 2019 08:36PM UTC	2	78.41	Travis Job 324.30

collectiveidea / delayed_job_active_record / 324
87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 324

collectiveidea / delayed_job_active_record / 324 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 324

collectiveidea / delayed_job_active_record / 324
87%

README BADGES
x