499
69%

Ran 07 Nov 2019 04:41AM UTC

Jobs 2

Files 160

Run time 50s

Badge

Embed ▾

pending completion

Build # 499

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Allow only system failures to trigger circuit breaker (#667)

* Allow only system failures to trigger circuit breaker

When the downstream client call fails due to application errors, we should not count that towards
the circuit breaker threshold.  The systems are still behaving okay.

For tchannel, it is the "system errors"
For http downstream, we sorta count 5xx as system failures. This may not always be the case, but is there a better way?
For grpc downstream, all exceptions are system errors, so things should be okay.

* fixed an oops, return value overwriting error

* Code review comments + fix bug

* rename plus one bug fix

Run Details

8590 of 12329 relevant lines covered (69.67%)

1.39 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	499.1	07 Nov 2019 04:41AM UTC	0	69.67	Travis Job 499.1
2	499.2	07 Nov 2019 04:41AM UTC	0	69.67	Travis Job 499.2

Source Files on build 499

Detailed source file information is not available for this build.

uber / zanzibar / 499
69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 499

uber / zanzibar / 499 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 499

uber / zanzibar / 499
69%

README BADGES
x