jekyll / jekyll-admin / 1709

73%

push

travis-ci

Refactor JekyllAdmin::Directory (#522)

* Use strings as keys for `#to_liquid` hash
  Provides consistency with other datatypes that uses a Hash with string keys. Moreover string 
  literals are automatically frozen now. Therefore, they're as performant as using symbols.

* Use constants to avoid creating objects repeatedly
  Creating the same array on every call / iteration is wasteful. String literals are now frozen
  automatically. So they need not be stashed in a constant

* Improve readability of constructor
  Pathname.new(nil) is an invalid usage. So technically all of the named parameters except
  `:content_type` is a required parameter. But content_type being nil doesn't make sense so that
  should be a required parameter as well.

* Base of a directory is its main container
  For `pages`, it would be site.source
  For `posts`, it would be site.source + collections_dir + '_posts'.  Similarly for other documents, it
  would be the path upto their respective collection's root directory,

* Memoize relative_path method
  To avoid re-evaluation on every request to a given API URL. The `to_liquid` method is not 
  memoized instead so that `modified_time` is picked up properly.

1040 of 1392 branches covered (74.71%)

Branch coverage included in aggregate %.

2278 of 2772 relevant lines covered (82.18%)

23.73 hits per line