585
73%

Ran 03 Nov 2019 08:13AM UTC

Jobs 5

Files 120

Run time 2min

Badge

Embed ▾

Committed 15 Sep 2019 03:41PM UTC coverage: 60.653% (-4.8%) from 65.471%

Build # 585

Build Type

cron

travis-ci

Committed by

jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

4088 of 6740 relevant lines covered (60.65%)

24615.11 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	585.1	03 Nov 2019 08:15AM UTC	75.43	Travis Job 585.1
2	585.2	03 Nov 2019 08:13AM UTC	81.46	Travis Job 585.2
3	585.3 (GO111MODULE=on)	03 Nov 2019 08:13AM UTC	60.65	Travis Job 585.3
4	585.4 (GO111MODULE=on)	03 Nov 2019 08:13AM UTC	60.65	Travis Job 585.4
5	585.5 (GO111MODULE=on)	03 Nov 2019 08:15AM UTC	60.65	Travis Job 585.5

Source Files on build 585

Detailed source file information is not available for this build.

openzipkin / zipkin-go / 585
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 585

openzipkin / zipkin-go / 585 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 585

openzipkin / zipkin-go / 585
73%

README BADGES
x