agsh / onvif / 456

74%

Build Type

push

travis-ci

Committed by Roger Hardiman

Commit Message

Remove subscriptionReference check in PullMessageResponse

The ONVIF Core Spec is a bit vague but from what I can understand an Event message
that comes back from a PullMessage command does
not need to include a subscriptionReference (and HikVision don't send it)

If the library used the other events mechanism, where
the NVT sends a Notity message to this llibrary then we would check the subscriptionReference.
But this library does not support that method of events.

Thanks to
Michiel Mooring @Gielert who reported the issue
Nick Whyte @nickw444 - who has used this in his fork

Run Details

471 of 691 branches covered (68.16%)

1 of 1 new or added line in 1 file covered. (100.0%)

622 of 702 relevant lines covered (88.6%)

69.16 hits per line