modflowpy / flopy / 2126

73%

push

travis-ci

refactor(SfrFile): detect other column names, remove methods (#708)

* Detect names for column 16 and beyond (checked against gwf2sfr7_NWT.f),
  which adds either 'gradient' or 'Qwt', 'delUzstor', sometimes 'gw_head';
  note that this may affect users that used (e.g.) df.col16.values
* Remove methods that are used once: get_skiprows_ncols and _set_names,
  as this logic is best handled in the class constructor
* Add notes to docstring to indicate which columns have indexing starting
  at one or zero
* Expand docstring for parameters, verbose and geometry are ignored
* Flake8's F841 variable assigned but never used for 'per' and 'timestep'
* Flake8's F402 import 'np' from line 1 shadowed by loop variable
* Resolve sfroutputfile.py:170: RuntimeWarning: invalid value encountered
  in less: newper = df.segment.diff().values < 0
* Expand t009_test.py to check attributes: ncol, names and times

30 of 30 new or added lines in 1 file covered. (100.0%)

96253 of 137073 relevant lines covered (70.22%)

2.26 hits per line