ladybug-tools / ladybug-geometry / 215

96%

master: 93%

Build Type

push

travis-ci

Committed by Chris Mackey

Commit Message

fix(poltface): Fix tolerance issue within the Polyface3D class

The previous bug had a bit of a larger scope than I realized but I think that this should address it. Unfortunately, this means that the tolerance is needed to re-create the Polyface3D to its original state whenever it's re-serialized from_dict. This also means that honeybee Rooms and Models have this restriction and I am going to add tolerance inputs to those classmethods as well. However, this is much more preferable to being forced to have incorrect Face normals, which is what we would have to do previously. I'll use a default tolerance of 0 so that people aren't always forced to supply it if they don't care about Face normals or they actually have made a model that is good down to 0 tolerance.

Run Details

18 of 18 new or added lines in 1 file covered. (100.0%)

7778 of 8100 relevant lines covered (96.02%)

1.92 hits per line