apache / bookkeeper / 617

72%

Build Type

push

jenkins

Committed by Enrico Olivelli

Commit Message

Removed mutex contention on BufferedChannel

### Motivation

Contention on `BufferedChannel` between the journal thread and the ForceWriteThread was introduced in #1228.

`unpersistentBytes` is only used if `unpersistedBytesBound > 0`, which is not true by default. We shouldn't be paying the penalty if not needed.

Also `position` doesn't need to be `AtomicLong` since it's only updated while the mutex is taken. Using a volatile will have the same effect with less overhead.


Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <zhaijia@apache.org>

This closes #2187 from merlimat/buffered-channel-contention

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

28235 of 39328 relevant lines covered (71.79%)

0.72 hits per line