preactjs / preact / 6032

100%

push

travis-ci

Simplify ternary expressions (-7 B) (#2049)

After working on #2048, I realized we had some gnarly ternary expressions that would a little hard to decipher. I played around with rewriting some into normal if statements hoping terser would properly minify them for us and it turns it did even better and saved us some bytes! A before and after comparison is provided in the comments of the PR for those curious.

Summary:
f6b39b5 Use if statement in setStyle for readability (+0 B)
8ff18fc Simplify className conditionals (-2 B)
f04da34 Simplify setState/_nextState condintional (-2 B)
f638098 Simplify update condition (-1 B)
448dbe7 Simplify nextState assignment in gDSFP handling (-2 B)

845 of 855 branches covered (98.83%)

18 of 18 new or added lines in 3 files covered. (100.0%)

912 of 914 relevant lines covered (99.78%)

770.57 hits per line