cilium / cilium / 11650
39%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 454
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 45.366%. Remained the same
11650

push

travis-ci-com

ianvernon 
daemon: group cleanup-related variables into type

Group into a type, and also add a mutex to protect setting of the `sigHandlerCancel` variable,
which is set after the instance of the type is created. This ensures that if the daemon
is stopped, that access to setting / getting this variable is synchronized. Add a nil check to
when we try to invoke `sigHandlerCancel` in case it hasn't been set yet, as if it is not,
Cilium will panic:

```
Oct 29 20:08:58 runtime systemd[1]: Stopping cilium...
Oct 29 20:08:58 runtime cilium-agent[15285]: panic: runtime error: invalid memory address or nil pointer dereference
Oct 29 20:08:58 runtime cilium-agent[15285]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2d4d098]
Oct 29 20:08:58 runtime cilium-agent[15285]: goroutine 29 [running]:
Oct 29 20:08:58 runtime cilium-agent[15285]: main.registerSigHandler.func1(0xc00044a600, 0xc0000ac5a0)
Oct 29 20:08:58 runtime cilium-agent[15285]: /home/vagrant/go/src/github.com/cilium/cilium/daemon/cleanup.go:69 +0x1f8
Oct 29 20:08:58 runtime cilium-agent[15285]: created by main.registerSigHandler
Oct 29 20:08:58 runtime cilium-agent[15285]: /home/vagrant/go/src/github.com/cilium/cilium/daemon/cleanup.go:65 +0x115
Oct 29 20:08:58 runtime systemd[1]: cilium.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Oct 29 20:08:58 runtime systemd[1]: cilium.service: Failed with result 'exit-code'.
```

Signed-off by: Ian Vernon <ian@cilium.io>

26114 of 57563 relevant lines covered (45.37%)

1556.6 hits per line

Jobs
ID Job ID Ran Files Coverage
1 11650.1 0
45.37
 Travis Job 11650.1
Source Files on build 11650
Detailed source file information is not available for this build.