preactjs / preact / 5966

100%

push

travis-ci

Separate debug tests into multiple files and fix some bugs in debug (#2047)

Previously the debug tests attempted to reset the options object before each test (I think at my suggestion originally lol) to reset the debug state before each test. However, by deleting the options properties, it deleted the hooks options and compat options. It also didn't delete every option so some options would continue to work. This behavior lead to tests that weren't resilient to changes and didn't capture bugs.

To improve our debug tests, I separated the tests out into different files. Each test file only initializes the debug options once. This behavior better mimics what our users do making our tests more closely match our user's behaviors.

Further, some debug behavior changes based on which modules you import (e.g. if you use compat we don't warn on string refs). So separating out the debug tests into different files (one test file imports compat, another doesn't) allows us to simulate these differing behaviors more reliable.

If nothing else, the debug.test.js file was pretty big so making it a little smaller is kinda nice :)

This PR also fixes a bug where if different instances of the same component wouldn't print warnings since they share the same constructor (more details in the comments of the PR).

846 of 857 branches covered (98.72%)

888 of 890 relevant lines covered (99.78%)

785.62 hits per line