530
100%
master: 100%

Ran 28 Oct 2019 12:04PM UTC

Jobs 4

Files 96

Run time 3min

Badge

Embed ▾

pending completion

Build # 530

Build Type

push

travis-ci

Committed by

dmagliola

Commit Message

Fix bug where different label orders lead to different results

In the DirectFileStore, in order to store the labels hash on disk, we
turn it into a "querystring". The way this is done, we'll end up with
different strings if the same hash is passed in with its keys in
different order.

Since this string is used to index into the file where we store the data,
this will lead to two different values being stored for the same hash.
This is fine in cases where the aggregation is :SUM, because they end up
getting summed when the Client is summarizing. But in :ALL aggregation,
for example, you will end up with one value or the other, randomly.

The test in this commit reproduces this problem.

This way of serializing the labels is a bit slower (see PR for details),
but it's not a huge impact in the big scheme of things, and it leads to
the correct result.

Run Details

4485 of 4485 relevant lines covered (100.0%)

44.64 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	530.1 (2.3.8)	28 Oct 2019 12:04PM UTC	100.0	Travis Job 530.1
2	530.2 (2.4.5)	28 Oct 2019 12:04PM UTC	100.0	Travis Job 530.2
3	530.3 (2.5.3)	28 Oct 2019 12:04PM UTC	100.0	Travis Job 530.3
5	530.5 (jruby-9.1.9.0)	28 Oct 2019 12:07PM UTC	0.0	Travis Job 530.5

Source Files on build 530

Detailed source file information is not available for this build.

prometheus / client_ruby / 530
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 530

prometheus / client_ruby / 530 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 530

prometheus / client_ruby / 530
100%
master: 100%

README BADGES
x