• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

apache / bookkeeper / 610
72%

Build:
DEFAULT BRANCH: master
Ran 23 Oct 2019 03:35PM UTC
Jobs 1
Files 539
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
610

push

jenkins

GitHub
[DLOG] LogReader shouldn't be added to pending if not locking

The pendingReaders set in BKDistributedLogManager exists so that if
the manager is closed which the lock is being acquired for a reader,
that reader will be closed (even though it hasn't been returned to the
client).

In the case that the reader is opened without a lock, there
is not async action being performed. Previously we were also adding
these readers to the pendingReaders, but they were never being removed
from the pendingReaders, causing a memory leak. This change avoids
adding no-locking readers to pendingReaders.


Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2185 from ivankelly/orphan-reader

28189 of 39320 relevant lines covered (71.69%)

0.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 610.1 23 Oct 2019 03:36PM UTC 0
71.69
Source Files on build 610
Detailed source file information is not available for this build.
  • Back to Repo
  • Jenkins Build #610
  • 4f56edf0 on github
  • Prev Build on master (#609)
  • Next Build on master (#611)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc