cilium / cilium / 11508
39%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 455
Run time 55s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 45.354% (-0.008%) from 45.362%
11508

push

travis-ci-com

gandro 
endpoint: Check interface value of proxy field

Check a value of the "proxy" field when detecting whether the L7
proxy is disabled.

In Go, an interface value is nil, if both type and value of the
interface are unset [1]. Therefore, when checking whether the proxy
is enabled, we need to check also for its value.

Fixes the following error when running cilium-agent with
`--install-iptables-rules=false` and `--masquerade=false`:

```
github.com/cilium/cilium/pkg/proxy.(*Proxy).UpdateNetworkPolicy(0x0, 0x38d1140, 0xc001078000, 0xc00005a640, 0xc000990000, 0xc00005a5c0, 0x5daf3749, 0x24358b28, 0x17432d246ba)
        /go/src/github.com/cilium/cilium/pkg/proxy/proxy.go:640 +0x26
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).updateNetworkPolicy(0xc001078000, 0xc00005a5c0, 0x4ed36c0, 0x1, 0x1)
        /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:86 +0xa2
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).runPreCompilationSteps(0xc001078000, 0xc00090a000, 0x0, 0x0)
        /go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:740 +0xb04
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerateBPF(0xc001078000, 0xc00090a000, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:503 +0x1e0
github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerate(0xc001078000, 0xc00090a000, 0x0, 0x0)
        /go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:341 +0xa5c
github.com/cilium/cilium/pkg/endpoint.(*EndpointRegenerationEvent).Handle(0xc000ebf560, 0xc0007dcb40)
        /go/src/github.com/cilium/cilium/pkg/endpoint/events.go:57 +0x459
github.com/cilium/cilium/pkg/eventqueue.(*EventQueue).Run.func1()
        /go/src/github.com/cilium/cilium/pkg/eventqueue/eventqueue.go:260 +0x187
```

[1]: https://golang.org/doc/faq#nil_error

Signed-off-by: Martynas Pumputis <m@lambda.lt>

26169 of 57699 relevant lines covered (45.35%)

1913.57 hits per line

Jobs
ID Job ID Ran Files Coverage
1 11508.1 0
45.35
 Travis Job 11508.1
Source Files on build 11508
Detailed source file information is not available for this build.