spotify / missinglink / 204

79%

master: 80%

Pull #61

travis-ci

remove Guava from missinglink-core

In the interest of having as few dependencies as possible in the core
module, this commit removes Guava from it.

Guava was only really used in three ways in the core module:

1. Immutable collection types
2. Preconditions checks
3. Joiner for concatenating strings

I replaced 1 with a mix of `Collection.singleton()`, `singletonList()`
etc., along with vanilla ArrayList / HashMap usage. The classes
generated by AutoMatter for POJOs will make copies of any collections
passed in, so I skipped a lot of the usage of Guava's Immutable types
for making copies of collections before passing them into the generated
POJOs.

Use of the Preconditions static methods to throw NullPointerExceptions
or IllegalArgumentExceptions I replaced with
`java.util.Objects.checkNotNull()` or vanilla if-else checks.

The plugin module still uses Guava; removing it from that module was out
of scope for this change (anyone using Missinglink in other build tools
will just depend on the core module).

Closes #60.

47 of 47 new or added lines in 7 files covered. (100.0%)

424 of 539 relevant lines covered (78.66%)

205694.87 hits per line