1316
97%

Ran 21 Oct 2019 09:28AM UTC

Jobs 2

Files 109

Run time 21s

Badge

Embed ▾

pending completion

Build # 1316

Build Type

push

travis-ci

Committed by

mbrodala

Commit Message

[BUGFIX] Use magic getter method as last attempt (#480)

* [BUGFIX] Use magic getter method as last attempt

Prevents issues with greedy magic methods being
called when a (public) property of the same name
exists in the class.

Specifically, does the following:

* Reverts deprecated VariableExtractor to previous
  behavior of letting a PHP warning be raised for
  protected getter methods. Removes the test that
  asserted this behavior (but kept it for StandardVariableProvider!)
* Switches both method_exists() and is_callable() to
  use instead a "study object" method that extracts
  all PUBLIC methods, disregarding __call, and fixing
  the problem that method_exists() returns TRUE for
  protected methods, and the problem that is_callable()
  returns TRUE for literally any method name.
* Slightly improves the internal logic of StandardVariableProvider
  and refactors it to call the "study object" method
  before checking if getters or asserter methods exist.

Close: #479

* [TASK] Rename studyObject to populateGettersByClassName

Clarify that method populates an array.

Run Details

2643 of 2728 relevant lines covered (96.88%)

91.44 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1316.1	21 Oct 2019 09:28AM UTC	0	96.98	Travis Job 1316.1
2	1316.2	21 Oct 2019 09:28AM UTC	0	96.89	Travis Job 1316.2

Source Files on build 1316

Detailed source file information is not available for this build.

TYPO3 / Fluid / 1316
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1316

TYPO3 / Fluid / 1316 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1316

TYPO3 / Fluid / 1316
97%

README BADGES
x