566
73%

Ran 20 Oct 2019 08:06AM UTC

Jobs 5

Files 99

Run time 2min

Badge

Embed ▾

Committed 15 Sep 2019 03:41PM UTC coverage: 66.867% (-1.4%) from 68.24%

Build # 566

Build Type

cron

travis-ci

Committed by

jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

3889 of 5816 relevant lines covered (66.87%)

21963.96 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	566.1	20 Oct 2019 08:08AM UTC	75.43	Travis Job 566.1
2	566.2	20 Oct 2019 08:06AM UTC	81.46	Travis Job 566.2
3	566.3 (GO111MODULE=on)	20 Oct 2019 08:06AM UTC	60.65	Travis Job 566.3
4	566.4 (GO111MODULE=on)	20 Oct 2019 08:06AM UTC	60.65	Travis Job 566.4
5	566.5 (GO111MODULE=on)	20 Oct 2019 08:08AM UTC	60.65	Travis Job 566.5

Source Files on build 566

Detailed source file information is not available for this build.

openzipkin / zipkin-go / 566
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 566

openzipkin / zipkin-go / 566 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 566

openzipkin / zipkin-go / 566
73%

README BADGES
x