reanahub / reana-workflow-controller / 1074

63%

push

travis-ci

<a href="https://github.com/reanahub/reana-workflow-controller/commit/<a class=hub.com/reanahub/reana-workflow-controller/commit/2840cbadf914fedf095554e37ecc043d5f9c5916">2840cbadf<a href="https://github.com/reanahub/reana-workflow-controller/commit/2840cbadf914fedf095554e37ecc043d5f9c5916">&quot;&gt;Revert &amp;quot;consumer: removes unused task&quot;

This reverts commit </a><a class="double-link" href="https://github.com/reanahub/reana-workflow-controller/commit/<a class="double-link" href="https://github.com/reanahub/reana-workflow-controller/commit/441e28b905ef21d33abc2fe5f1972b42f14f7f12">441e28b90</a>">441e28b90</a><a href="https://github.com/reanahub/reana-workflow-controller/commit/2840cbadf914fedf095554e37ecc043d5f9c5916">.

* We are correctly using the
  [TTLSecondsAfterFinished](https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished),
  and it really works, but the subtle detail is that RJC never
  finishes. One can see this by checking how many ready containers
  are inside the pod, Workflow Engine finishes and RJC still runs,
  see:
  ```console
  $ kubectl get pod \
            batch-serial-a0f3f1c4-161d-461c-94e0-c4dae1000b2f-nv8bb -o json | \
    jq &#39;.status.containerStatuses[] | .name + &quot; &quot; + (.ready|tostring)&#39;
      &quot;job-controller true&quot;
      &quot;workflow-engine false&quot;
  ```
  Because of this we need to manually delete the batch- containers
  with the task that was removed in the previous commit
  (closes #258).

664 of 1020 relevant lines covered (65.1%)

0.65 hits per line