firebase / firebase-js-sdk / 9868

0%

push

travis-ci

rxfire: Support collection groups & change detection fixess (#2223)

* rxfire was comparing documents based off ids, this was fine before collection group queries. Here I've switched to `ref.isEqual` like I have done in AngularFire.
* When a document is modified, we were only replacing the single doc in the array; this would not always trip change detection in frameworks as `===` would still equal true on the top level. Splicing it creates a new array, which will fail `===` and trip change detection.
* Further, this was an issue with the other operations as we were using splice. I'm now slicing to clone the array before modifying.
* NIT: Visual Studio Code's settings, which are committed, were not setup to track the workspace's version of Typescript. This tripped me up a little at first.

6607 of 8062 branches covered (81.95%)

Branch coverage included in aggregate %.

20617 of 22257 relevant lines covered (92.63%)

4145.19 hits per line