453
99%

Ran 22 May 2015 10:08PM UTC

Jobs 1

Files 15

Run time 1s

Badge

Embed ▾

pending completion

Build # 453

Build Type

push

travis-ci

Committed by David Jensen

Commit Message

Iron out some creases in validation

* schemaFormValidate used model value for validation, so any ordinary validation message got changed to "required".
  This was since we validated the model value, we can't validate the viewValue since numbers wouldn't work. So we
  set the viewValue again to trigger parsers. This works fine in Angular 1.2 and in 1.3 it solves the problem, but
  introduces another. When setting the viewValue `undefined` in 1.2 we get a nice "required", but in 1.3 parsers
  aren't even called. So we add an extra check with required and ngModel.$isEmpty()
* In Angular 1.3 returning undefined from a parser automatically tacks on a 'parse' error. Instead we always return
  the viewValue and later in a special validator ('schemaForm') stop the model from getting updated. 'schemaForm'
  error gets filtered so it never hits the forms. In Angular 1.2 we return undefined since that doesn't tack on a
  'parse' error.

Run Details

618 of 874 relevant lines covered (70.71%)

93.17 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	453.1	22 May 2015 10:08PM UTC	0	70.71	Travis Job 453.1

Source Files on build 453

Detailed source file information is not available for this build.

json-schema-form / angular-schema-form / 453
99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 453

json-schema-form / angular-schema-form / 453 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 453

json-schema-form / angular-schema-form / 453
99%

README BADGES
x