preactjs / preact / 5724

100%

push

travis-ci

Properly flush nested setState callbacks (-6 B)  (#2010)

* Properly flush nested renderCallbacks (-3 B)

Previously, we would synchronously flush nested renderCallbacks. This behavior meant that nested setState calls would flush before there state was properly applied in diff, meaning DOM, props, etc. wouldn't have been updated for that setState call when the callback was run (though the state would be correct due to a shortcut we took).

This PR fixes this behavior by only invoking the renderCallbacks for the current setState call synchronously. Nested setState callbacks are queued and executed when those setState cals are applied.

* Update forceUpdate to match setState (-2 B)

* Ignore return value of renderCallbacks (-1 B)

819 of 845 branches covered (96.92%)

4 of 4 new or added lines in 2 files covered. (100.0%)

855 of 858 relevant lines covered (99.65%)

763.83 hits per line