558
73%

Ran 13 Oct 2019 08:02AM UTC

Jobs 5

Files 116

Run time 2min

Badge

Embed ▾

Committed 15 Sep 2019 03:41PM UTC coverage: 68.24%. Remained the same

Build # 558

Build Type

cron

travis-ci

Committed by

jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

4381 of 6420 relevant lines covered (68.24%)

25684.63 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	558.1	13 Oct 2019 08:04AM UTC	75.35	Travis Job 558.1
2	558.2	13 Oct 2019 08:02AM UTC	81.46	Travis Job 558.2
3	558.3 (GO111MODULE=on)	13 Oct 2019 08:02AM UTC	60.65	Travis Job 558.3
4	558.4 (GO111MODULE=on)	13 Oct 2019 08:02AM UTC	60.65	Travis Job 558.4
5	558.5 (GO111MODULE=on)	13 Oct 2019 08:05AM UTC	60.65	Travis Job 558.5

Source Files on build 558

Detailed source file information is not available for this build.

openzipkin / zipkin-go / 558
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 558

openzipkin / zipkin-go / 558 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 558

openzipkin / zipkin-go / 558
73%

README BADGES
x