cilium / cilium / 11251

39%

push

travis-ci-com

cilium: re-implement broken delete handler for prefilter

While testing prefilter I noticed that deletions don't work at all,
and they in-fact call the prefilter Insert() handler which is completely
wrong. Turns out that c0c3c213cba9 ("api: Refactor /prefilter API for
1.0") had some wrong assumptions about how prefilter CIDRs are updated.
E.g. pkg/client/prefilter.go would first get the list and diff a keepList
which is then pushed into Insert() assuming the other entries would get
evicted. Undo all this, and properly implement delete handler.

After this fix:

  # ./cilium/cilium prefilter list
  Revision: 2
  4.4.4.4/32
  2.2.2.2/32
  # ./cilium/cilium prefilter delete --cidr="4.4.4.4/32,2.2.2.2/32"
  Deleted 2 prefilter entries
  # ./cilium/cilium prefilter list
  Revision: 3
  #

Fixes: #9382
Related: #3478

Fixes: c0c3c213cba9 ("api: Refactor /prefilter API for 1.0")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

28 of 28 new or added lines in 3 files covered. (100.0%)

26070 of 57072 relevant lines covered (45.68%)

1203.33 hits per line