Coveralls logob

apache / commons-fileupload / 126

DEFAULT BRANCH: trunk
LAST BUILD BRANCH: FILEUPLOAD-274-RFC5987-compliance
Repo Added 17 Nov 2016 12:50AM UTC
Total Files 42
# Builds 60 Last
Badge
Badge Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7 Oct 2019 - 11:27 coverage remained the same at 78.727%
126

Pull #23

travis-ci

9181eb84f9c35729a3bad740fb7f9d93?size=18&default=identiconweb-flow 
FILEUPLOAD-302 JUnit Jupiter migration

This patch upgrades the project's testing framework from JUnit 4.12
to the modern JUnit Jupiter 5.5.2.

Since JUnit 5 Jupiter is not backwards compatible to JUnit 4.x (or
even JUnit Vintage), this patch is a bit large, even though a lot of
the changes are merely cosmetic (such as changing the argument order,
see details below). In order to make the reviewer's task as easy as
possible, this PR does not presume to use JUnit Jupiter's best
practices and all its new functionality, but only to migrate the
existing tests with as little change as possible. Following patches
may want to improve the tests by using some of JUnit Jupiter's new
features.

This patch includes the following changes:

1. Maven dependency changes:
 a. junit:junit was replaced with org.junit.jupiter:junit-jupiter.

2. Annotations:
 a. org.junit.jupiter.api.Test was used as a drop in replacement for
    org.juit.Test without arguments. See 3.ii. for handling of @Test
    annotations with an "expected" argument.
 b. org.junit.jupiter.api.BeforeEach was used as an drop in
    replacement for org.junit.Before.
 c. org.junit.jupiter.api.AfterEach was used as an drop in
    replacement for org.junit.After.

3. Assertions:
 a. org.junit.jupiter.api.Assertions' methods were used as drop in
    replacements for org.junit.Assert's methods with the same name in
    the simple case of an assertion without a message. In the case of
    an assertion with a message, org.junit.jupiter.api.Assertions'
    methods were used, but the argument order was changed - Assert's
    methods take the message as the first argument, while Assertions'
    methods take the message as the last argument.
 b. org.junit.jupiter.api.Assertions#assertThrows was used to assert
    that a specific exception was throws instead of an org.junit.Test
    annotation with an expected argument. As a side bonus, this
    change makes the tests slightly stricter, as now they can assert
    the... (continued)
Pull Request #23: FILEUPLOAD-302: JUnit Jupiter migration

940 of 1194 relevant lines covered (78.73%)

1.57 hits per line

Jobs
Coverage Job Files Covered Ran
78.73
 126.2 42 07 Oct 2019 12:25PM UTC Travis Job 126.2
78.73
 126.7 42 07 Oct 2019 12:32PM UTC Travis Job 126.7
Source Files on build 126