554
73%

Ran 07 Oct 2019 08:00AM UTC

Jobs 5

Files 116

Run time 3min

Badge

Embed ▾

Committed 15 Sep 2019 03:41PM UTC coverage: 68.24%. Remained the same

Build # 554

Build Type

cron

travis-ci

Committed by

jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

4381 of 6420 relevant lines covered (68.24%)

26399.27 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	554.1	07 Oct 2019 08:02AM UTC	75.43	Travis Job 554.1
2	554.2	07 Oct 2019 08:00AM UTC	81.46	Travis Job 554.2
3	554.3 (GO111MODULE=on)	07 Oct 2019 08:00AM UTC	60.65	Travis Job 554.3
4	554.4 (GO111MODULE=on)	07 Oct 2019 08:00AM UTC	60.65	Travis Job 554.4
5	554.5 (GO111MODULE=on)	07 Oct 2019 08:03AM UTC	60.65	Travis Job 554.5

Source Files on build 554

Detailed source file information is not available for this build.

openzipkin / zipkin-go / 554
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 554

openzipkin / zipkin-go / 554 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 554

openzipkin / zipkin-go / 554
73%

README BADGES
x