200
92%
master: 93%

Ran 02 Oct 2019 03:25PM UTC

Jobs 3

Files 2

Run time 8s

Badge

Embed ▾

pending completion

Build # 200

Build Type

Pull #45

travis-ci

Committed by

web-flow

Commit Message

Improve Observer tests

Basically all tests are rewritten here. Implementation details should
not be checked because tests are becoming fragile when it comes to any
refactoring.

What instead should be tested is the actual **public behavior** of the
library when using its public interfaces.

While doing all these changes the following assumptions about this codebase
have been made:
 - class fields which are prefixed with underscore (like `observer._onNext`)
 are intended to be private and thus should only be accessed by members of
 the same class or its subclasses
 - `observer.stopped` is a public **readonly** field and should never be
 modified by the outside world, because its role is considered to be
 purely informational

If the above assumptions are not correct, this will need to be discussed
further. These improvements of the tests are necessary to introduce any
changes which include refactoring of the `Observer` in order to fix some
bugs.

Pull Request Pull Request #45: Observer tests improvements

Run Details

1694 of 1838 relevant lines covered (92.17%)

70.86 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	200.1 (LUA="lua 5.1")	02 Oct 2019 03:25PM UTC	1	92.17	Travis Job 200.1
2	200.2 (LUA="lua 5.2")	02 Oct 2019 03:25PM UTC	1	92.17	Travis Job 200.2
3	200.3 (LUA="lua 5.3")	02 Oct 2019 03:25PM UTC	1	92.17	Travis Job 200.3

Source Files on build 200

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

bjornbytes / RxLua / 200
92%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 200

bjornbytes / RxLua / 200 92% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 200

bjornbytes / RxLua / 200
92%
master: 93%

README BADGES
x