3460
97%

Ran 01 Oct 2019 05:00PM UTC

Jobs 5

Files 388

Run time 3min

Badge

Embed ▾

pending completion

Build # 3460

Build Type

push

travis-ci

Committed by

brandur-stripe

Commit Message

Move to monotonic time for duration calculations (#857)

Drops the use of `Time.now` in favor of using the system's monotonic
clock for various operations that calculate and use elapsed duration.
The latter is preferable because in some cases `Time.now` can be
unstable, like if it's set manually by a system administrator or an NTP
daemon.

I don't expect that the previous code would actually have caused trouble
in the vast majority of normal situations, so I'm not going to backport
anything, but this seems like good hygiene.

For better or worse I had to wrap the monotonic time calls in a new
`Util` function because (1) the normal invocation is long enough to have
caused a lot of overruns on our 80 character line lengths, and (2)
Timecop doesn't stub the monotonic clock, so the `Util` method gives us
a nice place that we can stub on where necessary.

Run Details

7638 of 7946 relevant lines covered (96.12%)

2389.0 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3460.1 (2.3)	01 Oct 2019 05:02PM UTC	96.19	Travis Job 3460.1
2	3460.2 (2.4)	01 Oct 2019 05:02PM UTC	96.19	Travis Job 3460.2
3	3460.3 (2.5)	01 Oct 2019 05:00PM UTC	96.19	Travis Job 3460.3
4	3460.4 (2.6)	01 Oct 2019 05:02PM UTC	96.16	Travis Job 3460.4
5	3460.5 (jruby-9.2.7.0)	01 Oct 2019 05:03PM UTC	0.0	Travis Job 3460.5

Source Files on build 3460

Detailed source file information is not available for this build.

stripe / stripe-ruby / 3460
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3460

stripe / stripe-ruby / 3460 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3460

stripe / stripe-ruby / 3460
97%

README BADGES
x