546
73%

Ran 01 Oct 2019 07:57AM UTC

Jobs 3

Files 60

Run time 2min

Badge

Embed ▾

Committed 15 Sep 2019 03:41PM UTC coverage: 60.653% (-7.6%) from 68.24%

Build # 546

Build Type

cron

travis-ci

Committed by

jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

2044 of 3370 relevant lines covered (60.65%)

14967.24 hits per line

Jobs

ID	Job ID	Ran	Coverage
3	546.3 (GO111MODULE=on)	01 Oct 2019 07:57AM UTC	60.65	Travis Job 546.3
4	546.4 (GO111MODULE=on)	01 Oct 2019 07:57AM UTC	60.65	Travis Job 546.4
5	546.5 (GO111MODULE=on)	01 Oct 2019 07:59AM UTC	60.65	Travis Job 546.5

Source Files on build 546

Detailed source file information is not available for this build.

openzipkin / zipkin-go / 546
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 546

openzipkin / zipkin-go / 546 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 546

openzipkin / zipkin-go / 546
73%

README BADGES
x